Skip to content

feat(Webhook): allow setting withComponents #10792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2025
Merged

feat(Webhook): allow setting withComponents #10792

merged 3 commits into from
Mar 5, 2025

Conversation

sdanialraza
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Upstream:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@sdanialraza sdanialraza added this to the discord.js 15.0.0 milestone Mar 5, 2025
@sdanialraza sdanialraza requested a review from a team as a code owner March 5, 2025 03:22
@vercel Vercel
Copy link

vercel bot commented Mar 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 6:39pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2025 6:39pm

Jiralite
Jiralite reviewed Mar 5, 2025
View reviewed changes
Copy link
Member

@Jiralite Jiralite left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the brackets. This is for non-application-owned webhooks, so the "non-interactive" description is critical information.

...If I'm wrong, just ignore this.

@sdanialraza @Jiralite
docs: remove brackets
bd80128 
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
@sdanialraza sdanialraza requested a review from Jiralite March 5, 2025 15:47
@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Mar 5, 2025
@kodiakhq kodiakhq bot merged commit b7e334e into discordjs:main Mar 5, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Mar 5, 2025
@sdanialraza sdanialraza deleted the feat/allow-setting-with-components branch March 5, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@didinele didinele didinele approved these changes

@Jiralite Jiralite Jiralite approved these changes

@Qjuh Qjuh Qjuh approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
api support backport-candidate packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js 15.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sdanialraza @vladfrangu @didinele @Jiralite @Qjuh